Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable environment requirements filter #444

Closed
wants to merge 5 commits into from
Closed

Enable environment requirements filter #444

wants to merge 5 commits into from

Conversation

thbeu
Copy link
Contributor

@thbeu thbeu commented Nov 20, 2022 •
edited by jkowalleck
Loading

Resolves #435.

  • implement solution
  • implement tests
  • update the documentation

@thbeu thbeu requested a review from a team as a code owner November 20, 2022 16:34
@jkowalleck
Copy link
Member

seams like some standards and tests failed.
@thbeu, please follow https://github.com/CycloneDX/cyclonedx-python/blob/master/CONTRIBUTING.md

@thbeu
Copy link
Contributor Author

thbeu commented Nov 23, 2022

Please confirm that this PR is principally acceptable before I spend time on the tiny details (and it won't get merged).

@jkowalleck jkowalleck closed this Nov 24, 2022
@jkowalleck jkowalleck reopened this Nov 24, 2022
@KramNamez
Copy link

I've opened a PR against @thbeu's repo to fix these two issues.

@thbeu
Copy link
Contributor Author

thbeu commented Nov 25, 2022

I've opened a PR against @thbeu's repo to fix these two issues.

Thanks. Will check later today.

@jkowalleck
Copy link
Member

re #444 (comment)
will discuss this with @madpah

@thbeu
Copy link
Contributor Author

thbeu commented Nov 28, 2022

I've opened a PR against @thbeu's repo to fix these two issues.

Thanks. Merged it finally.

@KramNamez
Copy link

Glad to help!

@thbeu thbeu requested a review from jkowalleck November 28, 2022 15:09
thbeu
thbeu commented Nov 28, 2022
View reviewed changes
cyclonedx_py/client.py Outdated Show resolved Hide resolved
@tmeckel tmeckel mentioned this pull request Nov 30, 2022
Closed
@jkowalleck
Copy link
Member

@thbeu @KramNamez before putting more effort in this PR,
please read #435 (comment)

You will find good reasons why I will probably not merge this PR.
I see your solution working for your current use cases, but it appears to me not wholesome enough.
Therefore, i (temporary) closed this PR.

@jkowalleck jkowalleck closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KramNamez KramNamez KramNamez left review comments

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@jkowalleck jkowalleck Awaiting requested review from jkowalleck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter EnvironmentParser output by requirements file
3 participants
@thbeu @jkowalleck @KramNamez