fix: PURL for PyPI packages from 'conda list' have the correct format now #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Weber <[email protected]>
rolweber
force-pushed
the
pypi-in-conda
branch
from
93e61e8
to
4a2292f
Compare
|
Thanks for the PR, @rolweber. will have a proper review soon. |
jkowalleck
approved these changes
Dec 15, 2022
jkowalleck
changed the title
|
Thank you for the fix, @rolweber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #462.
When generating the purl, check for "conda" packages with pseudo channel and platform "pypi". Those are actually pip-installed packages in the conda environment. Generate a
pgk:pypipurl for them.