Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Regression from #67: Component with no Version produced invalid BOM in < 1.4 #150

Closed
madpah opened this issue Jan 27, 2022 · 0 comments · Fixed by #148
Closed

[BUG] Regression from #67: Component with no Version produced invalid BOM in < 1.4 #150

madpah opened this issue Jan 27, 2022 · 0 comments · Fixed by #148
Assignees
@madpah
Labels
bug Something isn't working schema 1.0 schema 1.1 schema 1.2 schema 1.3
Milestone
2.0.0

Comments

@madpah
Copy link
Collaborator

madpah commented Jan 27, 2022

As discussed in #67, version became optional for a Component in 1.4.

The fallback should be an empty string for versions prior to 1.4 if a Component has no version.

This is currently failing with release 1.3.0.
@madpah madpah added the bug Something isn't working label Jan 27, 2022
@madpah madpah added this to the 1.1.0 milestone Jan 27, 2022
@madpah madpah mentioned this issue Jan 27, 2022
Merged
madpah added a commit that referenced this issue Jan 27, 2022
@madpah
test: refactored fixtures for tests which has uncovered #150, #151 and …
df43a9b 
…#152

Signed-off-by: Paul Horton <[email protected]>
madpah added a commit that referenced this issue Jan 27, 2022
@madpah
fix: Components with no version (optional since 1.4) produce invalid …
70d25c8 
…BOM output in XML #150

Signed-off-by: Paul Horton <[email protected]>
madpah added a commit that referenced this issue Jan 27, 2022
@madpah
fix: regression introduced by first fix for #150
c09e396 
Signed-off-by: Paul Horton <[email protected]>
madpah added a commit that referenced this issue Jan 27, 2022
@madpah
fix: further fix for #150
1f55f3e 
Signed-off-by: Paul Horton <[email protected]>
@madpah madpah self-assigned this Feb 2, 2022
@madpah madpah linked a pull request Feb 2, 2022 that will close this issue
RELEASE 2.0.0 #148
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madpah madpah

Labels
bug Something isn't working schema 1.0 schema 1.1 schema 1.2 schema 1.3
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

RELEASE 2.0.0 CycloneDX/cyclonedx-python-lib
1 participant
@madpah