Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab 4 compatibility question #134

Open
yogevyuval opened this issue Oct 24, 2023 · 11 comments
Open

JupyterLab 4 compatibility question #134

yogevyuval opened this issue Oct 24, 2023 · 11 comments

Comments

@yogevyuval
Copy link

yogevyuval commented Oct 24, 2023

Hi,
Is jupyterlab-sql-editor compatible and check with JupyterLab version 4 and jupyterlab-lsp version 5.0.0? Asking because i'm getting erros activating the plugins with the new versions.

@cccs-nik
Thanks

@cccs-nik
Copy link
Collaborator

It's indeed not compatible yet, it hopefully should be soon.

@yogevyuval
Copy link
Author

It's indeed not compatible yet, it hopefully should be soon.

Thanks @cccs-nik that;'s good to hear, will keep track of the repo

@yogevyuval
Copy link
Author

@cccs-nik Checking in if you think you have some thoughts on when do you think you will look into JupyterLab 4.0?
Or specifiicaly if you know what will be the major changes, and how complicated the transition might be.

Today we are using JupyterLab 4.0, but jupyterlab-sql-editor is a perfect fit for some of our needs and we are really keen of using it

@cccs-nik
Copy link
Collaborator

Hey @yogevyuval, I got a local branch going last week but it's not building yet. I'm working on it whenever I get a chance and I'm hoping the transition isn't too complicated 🙂

@cccs-nik
Copy link
Collaborator

Hi again @yogevyuval. I pushed an alpha release for JupyterLab 4.0 support: https://pypi.org/project/jupyterlab-sql-editor/1.0.0a1/. It's not quite ready yet, notably the syntax highlighting is broken but the rest should hopefully be working fine enough. I'll get back to finishing the upgrade in 2024 🙂

@yogevyuval
Copy link
Author

Hi again @yogevyuval. I pushed an alpha release for JupyterLab 4.0 support: https://pypi.org/project/jupyterlab-sql-editor/1.0.0a1/. It's not quite ready yet, notably the syntax highlighting is broken but the rest should hopefully be working fine enough. I'll get back to finishing the upgrade in 2024 🙂

That's great progress! appreciate your work on this, looking forward for the syntax highlighting in 2024!

Happy holidays :)

@yogevyuval
Copy link
Author

@cccs-nik I see progress is being made - that's really cool! appreciate it.

One question regarding this - We are very excited to use this for our own usage, but we are going to need different markers (instead of relying on --start-spraksql we want to rely on a different string.) Do you think it would somehow be possible in the new version to support this customization? Thanks

@cccs-nik
Copy link
Collaborator

Hey @yogevyuval! Yeah I think that should be simple enough to implement.

@yogevyuval
Copy link
Author

Hey @yogevyuval! Yeah I think that should be simple enough to implement.

@cccs-nik oh that's great to hear! should I start using the current branch or are you expecting to create a more official release soon?

Btw - i'm up to chat (slack / teams etc') if you youd like some specific feedback or help.

@cccs-nik
Copy link
Collaborator

@yogevyuval Keep using the branch for now, we're not quite ready for JupyterLab 4 so I'll be supporting JupyterLab 3 for now if anything comes up and merging the fixes to the JupyterLab 4 branch. We unfortunately don't have a public facing communications channel yet so if you want to chat it would maybe be on something like a big public Slack channel. Let me know 🙂

@yogevyuval
Copy link
Author

@yogevyuval Keep using the branch for now, we're not quite ready for JupyterLab 4 so I'll be supporting JupyterLab 3 for now if anything comes up and merging the fixes to the JupyterLab 4 branch. We unfortunately don't have a public facing communications channel yet so if you want to chat it would maybe be on something like a big public Slack channel. Let me know 🙂

@cccs-nik Great, can you add me to any slack / other platform you already have? if so I will send you my email address.
Otherwise, we can try adding you to our slack, we just going to need your email

let me know what do you prefer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants