Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server returns HTTP 500 when adding new badlist tag #280

Open
jasper-vdhoven opened this issue Oct 25, 2024 · 5 comments
Open

Server returns HTTP 500 when adding new badlist tag #280

jasper-vdhoven opened this issue Oct 25, 2024 · 5 comments
Assignees
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working ui-frontend

Comments

@jasper-vdhoven
Copy link

jasper-vdhoven commented Oct 25, 2024

Describe the bug
When creating a new badlist tag through the Assemblyline UI, the server returns an HTTP 500 error.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Manage -> Badlist
  2. Click on Add an item to the badlist
  3. Select network.dynamic.domain as the tag type, foo.bar as the tag value and lorem ipsum as the Item Details
  4. Save the tag and the server responds with an HTTP 500 error

Expected behavior
In previous versions of AL this would successfully add a tag to the badlist. This feature still works when creating a new tag from an existing submission, it only appears when creating a new badlist item from scratch.

Screenshots
image

image

Environment (please complete the following information if pertinent):

  • Assemblyline Version: 4.5.0.56
  • Browser: Arc Version 1.66.0 (55166) - Chromium Engine Version 130.0.6723.70
@jasper-vdhoven jasper-vdhoven added assess We still haven't decided if this will be worked on or not bug Something isn't working labels Oct 25, 2024
@cccs-rs
Copy link
Contributor

cccs-rs commented Oct 25, 2024

Looks like a bug on the frontend side where the classification isn't being passed forward to the API (and the classification is required for adding an item), you can check the Payload tab to confirm but that's what I'm currently seeing on our test system.

@cccs-rs cccs-rs added ui-frontend accepted This issue was accepted, we will work on this at some point and removed assess We still haven't decided if this will be worked on or not labels Oct 25, 2024
@jasper-vdhoven
Copy link
Author

jasper-vdhoven commented Oct 29, 2024

Yeah, that is what I'm seeing as well, the classification element is an empty string (i.e. ""), similar to the id value. Is this id value also not meant to be empty?

al-bug

@cccs-rs
Copy link
Contributor

cccs-rs commented Oct 29, 2024

I believe for adding things to the list, having the id unset is fine because the system has to generate an identifier based on the information of the item.

@kam193
Copy link

kam193 commented Oct 30, 2024

Could it be that it had a similar root cause as #273 ?

@cccs-rs
Copy link
Contributor

cccs-rs commented Oct 30, 2024

Possibly but not entirely sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working ui-frontend
Projects
None yet
Development

No branches or pull requests

5 participants