Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .ConfigureAwait(false) calls on all awaits, causing deadlocks #134

Open
marc-costello opened this issue May 18, 2022 · 0 comments
Open

Comments

@marc-costello
Copy link

As a library, unless you explicitly need to capture context, every await call should be followed by a ConfigureAwait(false).

Reason being, as a library author, you don't know how this is going to be consumed. For example, in our case, we are throwing the context away earlier on in the process by using .ConfigureAwait(false), prior to calling this library. In turn, this causes a deadlock when we call the async methods in this library, and tasks never complete. This effectively means that we can't use the asynchronous library calls 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant