Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv4 Multiple Addresses Helper Function Wrapping Observable in Observable #322

Closed
arcsector opened this issue Oct 4, 2019 · 1 comment
Closed

IPv4 Multiple Addresses Helper Function Wrapping Observable in Observable #322

arcsector opened this issue Oct 4, 2019 · 1 comment

Comments

@arcsector
Copy link
Contributor

Issue Details

IPv4 Multiple Addresses Helper Function (create_ipv4_list_observables) calls create_ipv4_observable function, which returns Observable type, but then attempts to wrap the Observable type in an Observable using the Observable() class constructor.

Issue Fix

Don't do secondary wrapping, or don't return Observable type from create_ipv4_observable function.

Issue Location

Issue is in the helper functions here.
@arcsector arcsector mentioned this issue Oct 4, 2019
Merged
@emmanvg
Copy link
Contributor

emmanvg commented Oct 28, 2019

Closed by #323

@emmanvg emmanvg closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emmanvg @arcsector