Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle description on cybox Object class #300

Closed
rpiazza opened this issue Oct 24, 2017 · 5 comments
Closed

Handle description on cybox Object class #300

rpiazza opened this issue Oct 24, 2017 · 5 comments
Assignees
Milestone

Comments

@rpiazza
Copy link

rpiazza commented Oct 24, 2017

The code says it doesn't support this. The slider needs a place to put STIX 2.0 properties that can't be represented

@gtback
Copy link
Contributor

gtback commented Oct 24, 2017

Could you put it on the Description of the Observable instead? If not, we could add it to Object as well (it shouldn't be too hard, since it subclasses mixbox.Entity).

@gtback gtback added this to the v2.1.0.15 milestone Oct 24, 2017
@rpiazza
Copy link
Author

rpiazza commented Oct 25, 2017

That sounds like a good solution.

@rpiazza rpiazza closed this as completed Oct 25, 2017
@gtback
Copy link
Contributor

gtback commented Oct 26, 2017

I'm going to leave this open, but remove it from the v2.1.0.15 milestone, since it should be pretty easy. For the slider, we can stick with the Observable description option.

@gtback gtback reopened this Oct 26, 2017
@gtback gtback removed this from the v2.1.0.15 milestone Oct 26, 2017
@rpiazza
Copy link
Author

rpiazza commented Oct 27, 2017

Actually, it would be a lot better for the slider to able to attach missing properties to the Object, because when it is noticed missing the Observable isn't available without changing a lot of code.

@gtback
Copy link
Contributor

gtback commented Oct 31, 2017

Ok, I'll put it back in a milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants