Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content row block has inconsistent image sizes #1503

Closed
kevincrafts opened this issue Nov 25, 2024 · 8 comments · Fixed by #1529
Closed

Content row block has inconsistent image sizes #1503

kevincrafts opened this issue Nov 25, 2024 · 8 comments · Fixed by #1529
Assignees
Labels
bug Something isn't working

Comments

@kevincrafts
Copy link
Member

The content row block on this page (https://www.colorado.edu/initiative/cubit/education-workforce-training/undergraduate-student-resources), set to large teaser, is showing inconsistent image sizes.

The large teaser, and large teaser alternate, should use images that are a 2:1 aspect ratio, but here is showing some images that are square, and some that are 2:1.

image
@kevincrafts kevincrafts added the bug Something isn't working label Nov 25, 2024
@jnicholCU jnicholCU self-assigned this Nov 26, 2024
@kevincrafts
Copy link
Member Author

adding another example with a content grid block: https://www.colorado.edu/commencement/

image

@jnicholCU
Copy link
Contributor

Okay a couple issues we have:
The content row is using the same focal style as the grid so the image sizes were recently changed from 2:1 to 3:2 which is causing the sizing change.
For some reason focal point didn't update all the images with these specifications which is really weird as it has done it every time before.
I'm going to be making a new focal style for the content rows that are 2:1 while keeping the old focal wide for the content grids at 3:2.

I'll need to see how to regenerate these images though if focal point isn't going to do it automatically like it has before.

@jnicholCU
Copy link
Contributor

The first article in Article teasers will need to use the new 2:1 style as well so I'll update the templates accordingly for that. Will ping @patrickbrown-io if I have any concerns.

@jnicholCU
Copy link
Contributor

Found a weird problem with the row template where the first two images are displaying with the square image style no matter what.

@jnicholCU
Copy link
Contributor

Unlinked rows were displaying a different image style. Was a more simple fix than expected.

@jnicholCU
Copy link
Contributor

There looks to be a problem with image style regeneration. Going to set up a second ticket for that and discuss with the team tomorrow. PRs for the teasers should be up soon.

@jnicholCU
Copy link
Contributor

As of right now if you change the image and save the block + page. Then replace the image again with the one that is rendering improperly it should regenerate it's image style. It's a pain that it's not doing it automatically at the moment. Will look into why. Most likely guess is a bug was introduced into the focal point module.

@jnicholCU
Copy link
Contributor

Link for the ticket regarding the style generation issue: #1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants