Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: Bug Fixes, Layout Adjustments #1532

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Newsletters: Bug Fixes, Layout Adjustments #1532

merged 8 commits into from
Dec 4, 2024

Conversation

patrickbrown-io
Copy link
Contributor

@patrickbrown-io patrickbrown-io commented Dec 4, 2024

Bug Fixes

  • Removed the hard-coded "View on Website" link. This will link correctly to the Newsletter page it is generated from. The hard-coded link was due to a completely re-written header and was left in unintentionally from development.
  • Added stricter styling rules to force iOS devices to show images at the proper width. Previously they would all take on the same width on iPhones only.
  • The blue link color should now be consistent across the Newsletter, along with removing the underline link decoration.
  • Missing images should be fixed for complex site urls, but will need to be tested in production.

Layout Fixes

  • Adjusts spacing on the top of the newsletter. Previously there could be a large gap in between the header and the content if you intentionally left out fields such as the Intro Image or Intro Text. The conditional spacing has been tightened up to include for this case.
  • Text blocks will display at full width if there is only one in the section. Previously they would only take up 50% even if there was only one

Resolves #1515
Resolves #1514
Resolves #1511
Resolves #1508
Resolves #1507
Resolves #1528
Resolves #1510
Resolves #1522

@patrickbrown-io patrickbrown-io added bug Something isn't working change Modification to code without a functional change labels Dec 4, 2024
@jcsparks jcsparks merged commit 9ae0cd2 into main Dec 4, 2024
2 checks passed
@jcsparks jcsparks deleted the issue/1507 branch December 4, 2024 19:51
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Newsletters: Bug Fixes, Layout Adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working change Modification to code without a functional change
Projects
None yet
2 participants