Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM Version? #39

Open
timeimp opened this issue Mar 15, 2024 · 2 comments
Open

ESM Version? #39

timeimp opened this issue Mar 15, 2024 · 2 comments

Comments

@timeimp
Copy link

timeimp commented Mar 15, 2024

Using smpte-timecode in an Angular 17 project is emitting this error:

Warning: file.ts depends on 'smpte-timecode'. CommonJS or AMD dependencies can cause optimization bailouts.

Is there a roadmap for an ESM version of this plugin or is there anything I can do to help get an ESM verison of smpte-timecode released?

@m1tk4
Copy link
Contributor

m1tk4 commented Apr 2, 2024

apologies for the delay. I don't really have Angular context as part of the test suite to test / fix this. If you can come up with a pull request that resolves it without breaking other stuff I would definitely consider and appreciate it. Thanks.

@james-hu
Copy link

Although I know ESM is the "future", currently we are in a chaotic era - CommonJS and ESM both exist and many tools have issues supporting them at the same time. However, my personal experience in recent years has been, CommonJS is still the one that has the best support. Several times I ran into issues with ESM packages, and I couldn't work around. That's also why many packages have both ESM and CommonJS releases. So that I would like to suggest keeping this package as CommonJS if there must be a choice. Angular 17 was just giving an warning, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants