Skip to content

Commit

Permalink
- only pack the main/develop branch
Browse files Browse the repository at this point in the history
- ensure ResolvePluginReferences is called before CoreCompile and after default Restore
  • Loading branch information
Cryptoc1 committed Jan 4, 2024
1 parent 29f132f commit 98b5107
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ jobs:
run: dotnet build test/LethalCompany.SdkSample.csproj --no-restore

pack:
needs: [build]
if: startsWith(github.ref, 'refs/heads/main') || startsWith(github.ref, 'refs/heads/develop')

runs-on: windows-latest
steps:
- name: checkout
Expand Down Expand Up @@ -80,7 +81,6 @@ jobs:
path: .sdk

publish:
if: startsWith(github.ref, 'refs/heads/main') || startsWith(github.ref, 'refs/heads/develop')
needs: [pack]

runs-on: windows-latest
Expand Down
2 changes: 1 addition & 1 deletion src/Sdk/Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
<!--
Executes the `ResolvePluginAssemblies` task to resolve the reference assemblies of `ThunderDependency` items.
-->
<Target Name="ResolvePluginReferences" AfterTargets="RestorePlugins" DependsOnTargets="ResolveProjectReferences">
<Target Name="ResolvePluginReferences" BeforeTargets="CoreCompile" AfterTargets="RestorePlugins;Restore" DependsOnTargets="ResolveProjectReferences">
<ResolvePluginAssemblies AssetsFile="$(PluginAssetsFile)">
<Output ItemName="_PluginReference" TaskParameter="ResolvedAssemblies" />
</ResolvePluginAssemblies>
Expand Down

0 comments on commit 98b5107

Please sign in to comment.