Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Restructure our files #1590

Open
kevinunger opened this issue Aug 17, 2022 · 0 comments · May be fixed by #1638
Open

[Refactor] Restructure our files #1590

kevinunger opened this issue Aug 17, 2022 · 0 comments · May be fixed by #1638

Comments

@kevinunger
Copy link
Contributor

kevinunger commented Aug 17, 2022

Current structure of components:

.
├── Banner.vue
├── BigButton.vue
├── BlacksmithNav.vue
├── CBButton.vue
├── CardFrame.vue
├── CardFrameToggled.vue
├── CharacterArt.vue
├── CharacterBar.vue
├── CharacterNav.vue
├── CombatResults.vue
├── CurrencyConverter.vue
├── Hint.vue
├── Loader.vue
├── NavBar.vue
├── NftIcon.vue
├── NftOptionsDropdown.vue
├── Options.vue
├── P2EButton.vue
├── PartneredProject.vue
├── RightMenu.vue
├── SideBar.vue
├── SkeletonLoader.vue
├── SmallBar.vue
├── SmallButton.vue
├── StakeSelectorItem.vue
├── StaminaBar.vue
├── ViewLinks.vue
├── WeaponIcon.vue
├── WeaponIconNew.vue
├── WeaponInvetory.vue
├── WeaponPopover.vue
├── WeaponViewer.vue
├── modals
│   └── ModalContainer.vue
└── smart
    ├── AdminTab.vue
    ├── AdminTabs
    │   ├── BlacksmithAdmin.vue
    │   ├── BurningManagerAdmin.vue
    │   ├── CBKLandAdmin.vue
    │   ├── CryptoBladesAdmin.vue
    │   ├── PartnerVaultAdmin.vue
    │   ├── QuestsAdmin.vue
    │   ├── RaidAdmin.vue
    ├── PvPButton.vue
    ├── PvPCharacter.vue
    ├── PvPDivider.vue
    ├── PvPDuelModal.vue
    ├── PvPKickedModal.vue
    ├── PvPLeaderboards.vue
    ├── PvPNavBar.vue
    ├── PvPRewards.vue
    ├── PvPSeparator.vue
    ├── PvPShield.vue
    ├── PvPUnderAttackModal.vue
    ├── PvPWeapon.vue
    ├── QuestActions.vue
    ├── QuestCharacter.vue
    ├── QuestComponentIcon.vue
    ├── QuestRequirements.vue
    ├── QuestReward.vue
    ├── QuestRewards.vue
    ├── QuestRow.vue
    ├── QuestSubmissionModal.vue
    ├── QuestTemplatesDisplay.vue
    ├── QuestsList.vue
    ├── RoleGranter.vue
    ├── RoleRevoker.vue
    ├── SkillBalanceDisplay.vue
    ├── SpecialWeaponForgeModal.vue
    ├── WeaponGrid.vue
    ├── WeaponGridNew.vue
    └── WeaponRowGrid.vue
  • Hard to find stuff without using search
  • Slows down work and is an easy to-do

I'd like to have the components to be more organized.

Suggestion:

  • /quests(Quest*.vue)
  • /pvp (PvP*.vue)
  • /admin and /admin/admintabs
  • /layout (Banner, Navbar, ...); maybe add /layout/navigation
  • remove the /smart folder. I guess this was intended for resuable components?

Bonus:

  • We have a lot of files just floating around in the root fldr /src/; Sort them into /utils for pure js stuff we need (like listening for events globally) and into /enums /data /interfaces /types`
@jakehein jakehein self-assigned this Aug 22, 2022
@jakehein jakehein linked a pull request Sep 19, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants