-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add documentation section to the readme files. #42
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe pull request introduces several modifications across multiple Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
web/README.md (1)
55-57
: Documentation section looks good, consider adding frontend-specific guidelinesThe documentation section clearly communicates the dev branch requirement. Consider enhancing it with:
- Link to CONTRIBUTING.md for detailed contribution guidelines
- Frontend-specific documentation requirements (e.g., component documentation, props documentation)
android/README.md (2)
12-19
: Hardware and software requirements look comprehensiveGood addition of detailed requirements. However, there's a minor formatting issue in the heading.
-### Software Requirements: +### Software Requirements🧰 Tools
🪛 Markdownlint (0.37.0)
18-18: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
86-86
: Tech stack entry needs consistent formattingMaintain consistent formatting with other tech stack entries.
-Trustless Work API +**[Trustless Work API](https://docs.trustlesswork.com/trustless-work)**README.md (1)
106-108
: Consider enhancing the testing sectionWhile the reference to TEST.md is helpful, consider:
- Improving the sentence structure
- Adding a brief overview of what types of tests are covered
-Please see our [TEST.md](web/TEST.md) for details on how to successfully test our frontend. +Please refer to [TEST.md](web/TEST.md) for comprehensive guidance on frontend testing, including unit tests, integration tests, and end-to-end tests.🧰 Tools
🪛 LanguageTool
[style] ~108-~108: Style-wise, it’s not ideal to insert an adverb (‘successfully’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ...EST.md](web/TEST.md) for details on how to successfully test our frontend. ## 📜 License This project is licens...(SPLIT_INFINITIVE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
README.md
(1 hunks)android/README.md
(3 hunks)contracts/README.md
(1 hunks)web/README.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- contracts/README.md
🧰 Additional context used
🪛 Markdownlint (0.37.0)
android/README.md
18-18: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
🪛 LanguageTool
README.md
[style] ~108-~108: Style-wise, it’s not ideal to insert an adverb (‘successfully’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ...EST.md](web/TEST.md) for details on how to successfully test our frontend. ## 📜 License This project is licens...
(SPLIT_INFINITIVE)
🔇 Additional comments (2)
android/README.md (1)
77-79
: Documentation section maintains consistency
The documentation section aligns well with other README files in the project.
README.md (1)
102-104
: Documentation section effectively communicates branch strategy
The documentation section clearly outlines the development workflow and branch strategy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work my friend, lgtm! 🌾
Pull Request Overview
📝 Summary
Add documentation section to the readme.
🪧 Related Issues
🏁 Type of Change
Mark with an
x
all the checkboxes that apply (like[x]
).🔄 Changes Made
This PR updates the README.md files to clarify that all development happens on the dev branch and that pull requests should target the
dev
branch.Summary by CodeRabbit
New Features
Documentation