Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overload template_t::render to accept context as an r-value #465

Merged
merged 1 commit into from
Jun 20, 2022
Merged

overload template_t::render to accept context as an r-value #465

merged 1 commit into from
Jun 20, 2022

Conversation

aloussase
Copy link
Contributor

This allows us to do:

return crow::mustache::load("index.mustache").render({ { "key", "value" } });

Rather than:

crow::mustache::context ctx{ {"key", "value"} };
return crow::mustache::load("index.mustache").render(ctx);

@The-EDev
Copy link
Member

The-EDev commented Jun 20, 2022

CMake Error in CMakeLists.txt:

  Target "Crow" INTERFACE_INCLUDE_DIRECTORIES property contains path:


    "/drone/src/ASIO_INCLUDE_DIR-NOTFOUND"


  which is prefixed in the source directory.

@luca-schlecker any idea how to deal with this?

Edit: nevermind, seems like merging master fixed the issue

Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the delay, merging now

@The-EDev The-EDev merged commit d7b3106 into CrowCpp:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants