Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get app port #276

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Get app port #276

merged 2 commits into from
Nov 15, 2021

Conversation

nx10
Copy link
Contributor

@nx10 nx10 commented Nov 14, 2021

Fixes #275 .

@The-EDev
Copy link
Member

Thanks for the PR, although the unit test would probably need to use an automatically assigned port

@nx10
Copy link
Contributor Author

nx10 commented Nov 15, 2021

Do you mean by setting up a custom logger that parses the inital status message or just checking port != 0?

@The-EDev
Copy link
Member

The-EDev commented Nov 15, 2021 •
edited
Loading

Looking at the code again, your test looks just fine, sorry about the confusion.

Was there anything you wanted to add to the PR or is it ready to be merged?

@nx10 nx10 marked this pull request as ready for review November 15, 2021 12:49
@nx10
Copy link
Contributor Author

nx10 commented Nov 15, 2021

Thanks! It's ready to be merged.

@The-EDev The-EDev merged commit 8cf97cf into CrowCpp:master Nov 15, 2021
@The-EDev
Copy link
Member

All good, Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EDev The-EDev The-EDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get automatically assigned port after startup
2 participants
@nx10 @The-EDev