Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ssl testing #130

Merged
merged 8 commits into from
Sep 28, 2021
Merged

added ssl testing #130

merged 8 commits into from
Sep 28, 2021

Conversation

The-EDev
Copy link
Member

.pem section is commented out because i couldn't get crow to work with it. It should probably be addressed in a separate issue and PR.

closes #21

@The-EDev The-EDev requested a review from mrozigor April 17, 2021 06:47
mrozigor
mrozigor previously approved these changes Apr 17, 2021
@The-EDev The-EDev marked this pull request as draft April 17, 2021 17:52
@The-EDev The-EDev mentioned this pull request Sep 1, 2021
@The-EDev The-EDev changed the base branch from master to revamped_setup September 27, 2021 21:50
@The-EDev
Copy link
Member Author

I canceled the build because currently revamped_setup doesn't work due to a problem with CROW_AMALGAMATE

@The-EDev The-EDev marked this pull request as ready for review September 27, 2021 21:51
@The-EDev
Copy link
Member Author

@luca-schlecker You said you wanted to make some adjustments, I changed the base to revamped_setup and changed what I could see, did I miss anything?

@luca-schlecker
Copy link
Collaborator

@The-EDev Looking good. 👍

@The-EDev The-EDev merged commit 53d746e into revamped_setup Sep 28, 2021
@The-EDev The-EDev mentioned this pull request Sep 29, 2021
@The-EDev The-EDev deleted the ssl_test branch September 30, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests
3 participants