Added Catchall route to Crow #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the modified catchall-function example added the code moved to routing.h only the setter remained in app.h the integer return is removed i personally don't need the default parameters: without crow::response the catchall can take no effect and without crow::request you know nothing about the request i only imagine one case, this is to set custom error pages. so i don't thing default parameters have any big benefit here. "#ifdef CROW_CATCHALL" was only for me, to find my own modifications feel free to replace it
Add a catch-all handler 2nd version
CROW_CATCHALL #endif if moved
Add a catch-all handler 2nd version
the macro is similar to CROW_ROUTE, added example to cmake, added unit test, and documentation
mrozigor
reviewed
Apr 13, 2021
mrozigor
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @Tibbel's work in #121 and #122. Main differences are:
CROW_ROUTEis used (CROW_CATCHALL_ROUTE).CROW_ROUTE).Thanks again to @Tibbel for suggesting the idea and creating the first implementation.
closes #123