Serving static files using read() and asio::write() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using with instead of open and close removed while loop using one line to write the new file using unordered map instead of ordered map added indentation to the generated file
…le command would just hang until timeout without fully sending the file). Added 404 and fixed some issues with windows error message sendfile still incompatible with windows due to the stat function also changed the buffer size to 16KB
Test cannot actually test whether the file was sent or not since the test has no access to the socket itself (also idk how to get data that was passed through a socket)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would add the ability to serve static files.
Unlike my previous PR, this PR loads a file 16KB at a time then uses
asio::writeto push the 16KB through the socket, since it uses ASIO rather than thesendfile(), it works with SSL.Additionally, there were some problems with large (4.4MB) files where
sendfile()would not send the full file, instead hanging until the server times out.The performance difference is almost negligible (about 1ms for 700KB file and none for 4.4MB file). That's why I decided to use the 16KB method for both
httpandhttpsinstead of the hybrid system withsendfile()for http.I also wrote a test, though the test can only tell if the headers were proper and if the file was read, but not whether it was sent properly. This is due to the fact that a. I cannot access the socket and b. I wouldn't know what to do with it even if i could.
Requests to add arguments to the mime type file generator and returning a
404if the file isn't found both are added here.Regarding windows support, I do not have a windows machine, but the only reason windows might be unsupported would be the
stat()command, I admit I didn't look too far into whether or not it does support it or if it's just POSIX, so I kept the 'linux only' macros.Edit: I forgot to mention, for the test to work, a folder named
imgwith a file namedcat.jpgneed to be placed inside thebuildfolder, I'm not sure how to get around this since the system I'm testing is about serving static files