-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests #21
Comments
Update: Websockets suffer the same problem as request streaming, It sends data directly over the TCP socket (or SSL stream), which as far as I know isn't very testable, so aside from the setup code, there isn't much to test without some sort of fake read/write methods or some debug tools in ASIO (which I don't believe there are) Edit: a simple client to test the received data might be useful, though I do not believe code coverage and unit tests are important enough to warrant dropping the main issues to write a client, maybe when the code is in a stable state, or if someone kindly opens a PR with such a client implemented |
Ok so after some research, data coming through a socket by creating our own socket and connecting it to an ioservice, similar to how it's done in tests like |
It might be the case that Mustache Tests are not being considered in coverage. This could be due to the fact that the file being run is a python script that generates temporary files and runs the actual C++ test. Update: I confirmed GCOV files are only being created for unittest Update2: Adding a simple line to include |
SSL tests have been merged into |
websocket.h
is seemingly not being tested at all, should probably be addressedmustache.h
is quite low, not sure why, should probably be investigated.. mustachetest is not generating gcov filesAlso I think there's no testing for SSLThe text was updated successfully, but these errors were encountered: