Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remoteIpAddress in http_request.h uses camel case instead of snake case #199

Closed
noorwachid opened this issue Aug 14, 2021 · 3 comments · Fixed by #200
Closed

remoteIpAddress in http_request.h uses camel case instead of snake case #199

noorwachid opened this issue Aug 14, 2021 · 3 comments · Fixed by #200
Labels
good first issue an issue suitable to start contributing to the project task Non code related issue

Comments

@noorwachid
Copy link

I read the code and saw url_params then remoteIpAddress as public API (not internal code) are you planning on refactoring the code?
@The-EDev The-EDev added the task Non code related issue label Aug 14, 2021
@The-EDev
Copy link
Member

The convention for variable names is snake case, the remoteIpAddress slipped through the cracks. Thanks for finding it, feel free to open a PR fixing it or find others to fix. We'll fix it as soon as we can now that we know of it :)

@The-EDev The-EDev changed the title Refactor with modern/common conventions remoteIpAddress in http_request.h uses camel case instead of snake case Aug 14, 2021
@The-EDev The-EDev added the good first issue an issue suitable to start contributing to the project label Aug 14, 2021
@himanshu007-creator
Copy link
Contributor

hi i would like to work on this issue!

@The-EDev
Copy link
Member

sure thing @himanshu007-creator, go ahead and open a PR, I'll look into it and merge it :)

@himanshu007-creator himanshu007-creator mentioned this issue Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue an issue suitable to start contributing to the project task Non code related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update http_request.h
3 participants
@noorwachid @The-EDev @himanshu007-creator