Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to follow python conventions in converter.py #257

Merged
merged 3 commits into from
Oct 24, 2021
Merged

changes to follow python conventions in converter.py #257

merged 3 commits into from
Oct 24, 2021

Conversation

QuartzAl
Copy link
Contributor

changes include:

  • changes to variable names and spacing to follow python conventions

@QuartzAl
Copy link
Contributor Author

did not mean to include previous commits into this, my bad

@Dhruvacube
Copy link
Member

@QuartzAl then you can prolly close this pr then create a new one or you can closed the previous one and edit this pr to include both the changes, I will be reviewing your pr later! Btw thanks for contributing

@QuartzAl QuartzAl closed this Oct 24, 2021
@Dhruvacube Dhruvacube reopened this Oct 24, 2021
@Dhruvacube Dhruvacube merged commit 07ee35e into Creatrix-Net:master Oct 24, 2021
@Dhruvacube Dhruvacube added this to the v2.0 milestone Oct 27, 2021
@Creatrix-Net Creatrix-Net deleted a comment from allcontributors bot Mar 11, 2022
@Creatrix-Net Creatrix-Net deleted a comment from allcontributors bot Mar 11, 2022
Dhruvacube added a commit that referenced this pull request Jun 23, 2022
changes to follow python conventions in converter.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants