Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unnecessary else / elif when if block has a raise statement #254

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Refactor unnecessary else / elif when if block has a raise statement #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions minato_namikaze/bot_files/lib/classes/games/tictactoe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,13 @@ async def MakeMove(self, emoji: str, user: discord.Member) -> list:

if emoji not in self._controls:
raise KeyError("Provided emoji is not one of the valid controls")

else:
x, y = self._conversion[emoji]
piece = self._PlayerToEmoji[user]
self.board[x][y] = piece
self.turn = self.circle if user == self.cross else self.cross
self._conversion.pop(emoji)
self._controls.remove(emoji)
return self.board
x, y = self._conversion[emoji]
piece = self._PlayerToEmoji[user]
self.board[x][y] = piece
self.turn = self.circle if user == self.cross else self.cross
self._conversion.pop(emoji)
self._controls.remove(emoji)
return self.board

async def GameOver(self) -> bool:

Expand Down