Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PYL-R1720) Unnecessary else/elif used after raise #240

Closed
Dhruvacube opened this issue Oct 19, 2021 · 0 comments · Fixed by #254
Closed

(PYL-R1720) Unnecessary else/elif used after raise #240

Dhruvacube opened this issue Oct 19, 2021 · 0 comments · Fixed by #254
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@Dhruvacube
Copy link
Member

Description

raise causes control flow to be disrupted, as it will exit the block. It is recommended to check other conditions using another if statement, and get rid of else statements as they are unnecessary.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/The-4th-Hokage/yondaime-hokage/issue/PYL-R1720/occurrences/
@Dhruvacube Dhruvacube linked a pull request Oct 22, 2021 that will close this issue
Refactor unnecessary else / elif when if block has a raise statement #254
Merged
@Dhruvacube Dhruvacube added the enhancement New feature or request label Oct 22, 2021
@Dhruvacube Dhruvacube reopened this Oct 26, 2021
@Dhruvacube Dhruvacube added this to the v2.0 milestone Oct 27, 2021
@Dhruvacube Dhruvacube added this to v2.0 Jul 7, 2024
@Dhruvacube Dhruvacube moved this to Done in v2.0 Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
v2.0
Status: Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Refactor unnecessary else / elif when if block has a raise statement Creatrix-Net/yondaime-hokage
1 participant
@Dhruvacube