Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragonLauncher sub-launchers #593

Open
al-rigazzi opened this issue May 20, 2024 · 0 comments
Open

DragonLauncher sub-launchers #593

al-rigazzi opened this issue May 20, 2024 · 0 comments
Labels
area: Dragon area: launcher Issues related to any of the launchers within SmartSim type: feature Issues that include feature request or feature idea

Comments

@al-rigazzi
Copy link
Collaborator

Description

The steps belonging to the DragonLauncher attributes _pbs_launcher and _slurm_launcher should be managed in a better way.

Justification

Currently, when a DragonBatchStep is launched as a batch job using SbatchSettings or QsubSettings, a SlurmLauncher or PBSLauncher object is used to control it. Such launchers are stored as attributes of the DragonLauncher, and we call them sub-launchers. As SmartSim tracks jobs only by the ID assigned by the WLM to them, the DragonLauncher has no way of understanding whether a job id represents a Slurm or a PBS batch job. For that reason, we prefix the job id with the name of the sub-launcher. This workaround is not elegant and we should find a better way of handling such batch jobs.

Implementation Strategy

Instead of step id (integers or strings), SmartSim could use objects to track steps. For example, a _get_managed_step_update call, instead of using a list of ids, would use a list of StepID objects (these could be simple dataclass objects), and no id prefixing would be needed by the Dragon launcher, which could deduce the sub-launcher to call from the object type.

@al-rigazzi al-rigazzi added area: Dragon area: launcher Issues related to any of the launchers within SmartSim type: feature Issues that include feature request or feature idea labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Dragon area: launcher Issues related to any of the launchers within SmartSim type: feature Issues that include feature request or feature idea
Projects
None yet
Development

No branches or pull requests

1 participant