This repository has been archived by the owner on Jun 2, 2021. It is now read-only.
Dev jebyrnes #5
Open
Dev jebyrnes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I added in something to data-raw to make a covid19R compliant dataset that can be written out as a csv to your data archive. The refresh function then merely pulls the most recent version. You can update it as you update the main data for the package. This 1) allows this data to export to covid19Rdata and 2)does so while adding no new dependencies.
Note - merging with country and Province codes was a royal pain. Feel free to look at what I did (I pulled the codes from iso-3166-2.js instead of rnaturalearth to lower the dependencies) and then did a lot of substitutions in order to get the names to sync.
Sorry - wish I had been able to get this to you by 0.2!
Oh, btw, I currently have the write.csv statement commented out as I thought you might want to modify it.