From 15584800ad14e3a7ccf29287683587628086e9e4 Mon Sep 17 00:00:00 2001 From: DanielHabenicht Date: Wed, 28 Oct 2020 22:10:08 +0100 Subject: [PATCH] chore: fix title check (#267) Issue https://github.com/aslafy-z/conventional-pr-title-action/issues/63 was resolved add version tag so it does not automatically update --- .github/workflows/pr-title-check.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr-title-check.yml b/.github/workflows/pr-title-check.yml index 2dbce37d..6db5031e 100644 --- a/.github/workflows/pr-title-check.yml +++ b/.github/workflows/pr-title-check.yml @@ -12,7 +12,7 @@ jobs: lint: runs-on: ubuntu-latest steps: - - uses: aslafy-z/conventional-pr-title-action@master + - uses: aslafy-z/conventional-pr-title-action@v2.2.3 id: title-check with: success-state: Title follows the specification. @@ -32,8 +32,7 @@ jobs: body-includes: Please make sure that your Pull Request title and body does conform to this format - name: Create comment - # Attention title-check output is reversed: https://github.com/aslafy-z/conventional-pr-title-action/issues/63 - if: always() && (steps.fc.outputs.comment-id == 0) && (steps.title-check.outputs.success == 'true') + if: always() && (steps.fc.outputs.comment-id == 0) && (steps.title-check.outputs.success == 'false') uses: peter-evans/create-or-update-comment@v1 with: issue-number: ${{ github.event.pull_request.number }} @@ -53,8 +52,7 @@ jobs: In the Pull Request Body please describe what changes for the user of the application. If the user has to do Things different than before (excluding new functionality) please include `BREAKING CHANGE` at the end. This will trigger a major release (v1.0.0 -> v2.0.0) - name: Delete comment - # Attention title-check output is reversed: https://github.com/aslafy-z/conventional-pr-title-action/issues/63 - if: always() && (steps.fc.outputs.comment-id != 0) && (steps.title-check.outputs.success == 'false') + if: always() && (steps.fc.outputs.comment-id != 0) && (steps.title-check.outputs.success == 'true') uses: actions/github-script@v3 with: script: |