Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Combine Unload, large field range? ( Recheck if Trailer valid) #2372

Open
jonfive opened this issue Mar 9, 2023 · 12 comments
Open
Assignees
Labels
enhancement New feature or request FS25 Will check for fs25 low priority more a nice to have then rly needed

Comments

@jonfive
Copy link

jonfive commented Mar 9, 2023

Having a little bit of an issue where the wagon will go and unload the combine no problems.

At the start it finds the trailer that i have parked next to the field unloads the wagon into the trailer and continues to unload the combine perfectly.

This field is VERY big on the Huron Michigan 16x map. That said, when the unloader makes it's way to the opposite side of the field, it says no path found.

When it fails it says "Goal Node is invalid, abort pathfinding." When i move closer to the target trailer, it suddenly "finds" it and continues. The field is wide open with 3 headlands.

Is there a limited range that it can detect an unload point? If so, can that be extended?

fs1

fs2

@jonfive jonfive added the question Further information is requested label Mar 9, 2023
@Tensuko
Copy link
Contributor

Tensuko commented Mar 9, 2023

@pvaiko I don't think we have a limit in range?

@jonfive can you turn on debug channel for the unloader and start him once far away when he have to unload into trailer?
So that we have some more debug prints in the logfile, wich you can attach here.

@pvaiko
Copy link
Contributor

pvaiko commented Mar 9, 2023

No, there is no range limit.

On the first screenshot the log says your T8 tractor is colliding with the NL16-22 at the goal, and that, as far as I know is a silo, so looks like we are finding that silo and not the trailer (also note the different goal coordinates in the two screenshots), as it is closer to the tractor than the trailer.

If we had the full log, we could see all trailers the unloader finds and the one which it selects, and that is most likely the silo in the first case (incorrect) and the trailer is in the second case.

Why the silo is selected, I don't know, we are looking for trailers, depends on how that mod is implemented, may be a problem with the mod.

@pvaiko
Copy link
Contributor

pvaiko commented Mar 9, 2023

To correct myself, we probably find another trailer, which is at the silo, but still close enough to the field, and closer than the other trailer.

@jonfive
Copy link
Author

jonfive commented Mar 9, 2023

That's true, I do have a building with a different trailer in it that's sort of near the field and the silo is next to it.

When I get home I'll run it. Do you want me to just fill the auger wagon with the intended trailer at the same spot, leaving the harvester not operating?

@Tensuko
Copy link
Contributor

Tensuko commented Mar 9, 2023

Harvester is not needed to run.
As soon as the auger wagon is full and you start CP, it will look for a trailer to unload to.

@jonfive
Copy link
Author

jonfive commented Mar 9, 2023

log.txt

This is the log with the unloader NOT finding the trailer.

@jonfive
Copy link
Author

jonfive commented Mar 9, 2023

If it helps additionally at all, this is the point where it would find no path.
image

At this point, there was a path found and it began to head to the correct place.
image

@jonfive
Copy link
Author

jonfive commented Mar 9, 2023

Here is the same log that includes AFTER it was able to find the unload point.
I rolled slightly forward and back to find the exact point where it was able to find it and let it complete the unload at that point.
log.txt

@jonfive
Copy link
Author

jonfive commented Mar 9, 2023

Not sure if i figured it out totally, I saw in the log that it wanted to use the ASW trailer (which is in a shed). i moved the ASW trailer out of the shed and a few fields over and it found the correct trailer. Found immediately in the same spot before it had said no path.

Since that seems to have been the issue unless i'm completely off base. If that was it, is there a way to loop the search, excluding the unpathable target to find the next best trailer that it can path to?

Maybe an addition some point down the line, there could be an addition to select a preferred trailer to unload to, per auger wagon, for these cases of huge fields with a potential of another trailer nearby?

@pvaiko
Copy link
Contributor

pvaiko commented Mar 9, 2023

I don't think it tried to use the ASW.

Search for "best trailer" in the logs, that's the one it picks:

2023-03-09 16:26 :45 [dbg1 lp73964] T8.410 GENESIS/283: Best trailer is Fillable Metal Box at 388.6 meters, free capacity 5000, fill node 1

No idea what this "Fillable Metal Box" is, but that's the closest "trailer" we find, that seems to be the problem.

We ignore trailers which are not on the field or not within 20 meters of the field. Here, all trailers, including this mysterious fillable box seem to be on field 93 but your screenshot shows 94, not sure how your field layout looks like.

@jonfive
Copy link
Author

jonfive commented Mar 9, 2023

Ah yes, you're right. It was just a mod box where i could put woodchips and move it with pallet forks. I sold it.

It continued to do the same with the ASW. "Best trailer is ASW 271 at 350.2 meters, free capacity 29500, fill node 1" and fail as well. Once i moved it away it worked. Perhaps i'll give it a shot with custom fields, at least for that area so it can be marked correctly. Probably just map weirdness. Thanks a lot!

@Tensuko Tensuko changed the title [Question] Combine Unload, large field range? [Enhancement] Combine Unload, large field range? ( Recheck if Trailer valid) Mar 15, 2023
@Tensuko Tensuko added enhancement New feature or request and removed question Further information is requested labels Mar 15, 2023
@Tensuko
Copy link
Contributor

Tensuko commented Mar 15, 2023

Dev note:

Trailer geht nicht - suche weiteren:
A) gefunden und geht -> Abladen
B) gefunden und geht nicht -> Recheck wie auch Auger Wagon?
C) keinen gefunden -> Recheck wie auch Auger Wagon?

@Tensuko Tensuko added the low priority more a nice to have then rly needed label Sep 8, 2023
@Tensuko Tensuko added the FS25 Will check for fs25 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FS25 Will check for fs25 low priority more a nice to have then rly needed
Projects
None yet
Development

No branches or pull requests

3 participants