Fix Failing Course Deletion if Approved/Rejected Enrol Requests Exist #7642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cysjonathan
reviewed
Nov 18, 2024
| @@ -24,6 +24,7 @@ def create | |||
| # Allow users to withdraw their requests to register for a course that are pending | |||
| # approval/rejection. | |||
| def destroy | |||
| @enrol_request.is_validation_for_destroy_required = true | |||
There was a problem hiding this comment.
Since course deletion will bypass controller and go straight to model, why not move the workflow_state == 'pending' check to the controller instead?
Then we can save on an additional is_validation_for_destroy_required attribute which is only set in the controller destroy anyway.
There was a problem hiding this comment.
as discussed, we decided to move the validation logic for deletion to the controller instead of model, since the validation will only be called while destroying object through controller
bivanalhar
force-pushed
the
bivan/course-delete-enrol-request-fix
branch
from
a60bc37
to
4a68336
Compare
bivanalhar
force-pushed
the
bivan/course-delete-enrol-request-fix
branch
from
4a68336
to
4395490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously, having at least one Approved/Rejected enrol requests inside the course will give an error if one wants to delete the course
Root Causes
Based on this PR #4212, we wants to keep track on the enrol requests that are approved/rejected, and hence we disallow the requester to retract their enrol requests if theirs have been approved / rejected (not pending) by adding validation rules before destroying the enrol requests. However, this same validation will also takes place when we delete course, since
enrol_requestis the child ofcourseand henceenrol_requestwill be subsequently deleted due to cascading.Approach
We moved the validation for destroy towards
enrol_request_controller, since we noticed that the validation will only be accessed should we send the request through controller and not through parent deletion