Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React Query to v4 #5263

Open
nabramow opened this issue Nov 27, 2024 · 2 comments
Open

Upgrade React Query to v4 #5263

nabramow opened this issue Nov 27, 2024 · 2 comments

Comments

@nabramow
Copy link
Contributor

We should do this after upgrading to React 18. React v18 has introduced concurrent batching and v3 does not support this feature. Once the React upgrade is done we should do this one.
@nabramow nabramow converted this from a draft issue Nov 27, 2024
@nabramow nabramow moved this from Ready to Blocked in Couchers Engineering 💻 Nov 27, 2024
@nabramow
Copy link
Contributor Author

Blocked by #5167

@darrenvong
Copy link
Member

darrenvong commented Nov 27, 2024 •
edited
Loading

A quick tip - convert everything to use the object notation when calling useQuery / useInfiniteQuery in this so the further upgrade to v5 will be more seamless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Couchers Engineering 💻
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darrenvong @nabramow