Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce min gas fee for all transactions #58

Closed
blockcreators opened this issue Oct 4, 2021 · 7 comments
Closed

Enforce min gas fee for all transactions #58

blockcreators opened this issue Oct 4, 2021 · 7 comments
Labels
Priority This needs to be done ASAP

Comments

@blockcreators
Copy link
Contributor

Because smart contracts might use transaction information, we cannot just archive older chain states and start fresh.
So it might be good to have a minimum transaction fee. This would reduce spamming the chain with 0 fee transactions, thus filling up the chain state with useless transaction data.

@JakeHartnell JakeHartnell changed the title Min gas fee for all transactions Enforce min gas fee for all transactions Nov 8, 2021
@JakeHartnell
Copy link
Contributor

Network was able to be brought down with an attack from a malicious smart contract. This needs to be done.

@JakeHartnell JakeHartnell added the Priority This needs to be done ASAP label Nov 8, 2021
@blockcreators
Copy link
Contributor Author

Would be ideal to have the fee as a parameter so that governance can auto change it via voting.

@faddat
Copy link
Contributor

faddat commented Nov 9, 2021

Hot

@the-frey
Copy link
Contributor

the-frey commented Nov 9, 2021

Don't disagree about it being changed by governance, but if governance changes it to 0 for zone reason then the network is ☠️

@blockcreators
Copy link
Contributor Author

Don't disagree about it being changed by governance, but if governance changes it to 0 for zone reason then the network is ☠️

Governance could also vote to mint 1 trillionzillion coins and do the same thing :)

@the-frey
Copy link
Contributor

This is superceded by #82

@JakeHartnell
Copy link
Contributor

Network was able to be brought down with an attack from a malicious smart contract. This needs to be done.

In hindsight, not sure if this is needed. #82 should be enough. More risk from messing with this IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority This needs to be done ASAP
Projects
None yet
Development

No branches or pull requests

4 participants