Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry install downgrades numpy and fails #10

Closed
pllim opened this issue Mar 21, 2024 · 3 comments · Fixed by #17
Closed

poetry install downgrades numpy and fails #10

pllim opened this issue Mar 21, 2024 · 3 comments · Fixed by #17

Comments

@pllim
Copy link
Contributor

pllim commented Mar 21, 2024

Describe the bug

Trying to install using poetry install as documented but it fails with:

- Downgrading numpy (1.26.4 -> 1.24.4): Failed

Expected behavior

Just use installed numpy if compatible. Any reason why this is incompatible with numpy 1.26? There is no mention of such incompatibility in README.

Desktop (please complete the following information):

  • OS: Ubuntu (WSL2 on Windows 11)
  • Browser [e.g. chrome, safari] N/A
  • Version [e.g. 22] N/A

Additional context

This is part of:

@MetinSa
Copy link
Collaborator

MetinSa commented Mar 22, 2024

If you have time, could you check if this works as intended on the drop_py38 branch? If so, is it sufficient to just release a >=3.9 version as a fix to this?

@pllim
Copy link
Contributor Author

pllim commented Mar 22, 2024

Seems to work on drop_py38 but only after I run poetry lock also. Otherwise, I get this:

$ poetry install
Installing dependencies from lock file

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

Hope this helps!

@MetinSa
Copy link
Collaborator

MetinSa commented Apr 13, 2024

@pllim hopefully this is resolved in the latest merge where python 3.8 is dropped and the pyproject.tomland the lockfile are updated, but feel free reopen this issue if you notice any issues!

@MetinSa MetinSa closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants