FABMenu: memory issue (reference cycle)

[comaxime]

Hello,
I have found a problem of reference cycle between FABMenu and FABMenuController.

FABMenuController has a reference to FABMenu:

open class FABMenuController: RootController {
    open let fabMenu = FABMenu()
}

FABMenu has references to FABMenuController via the 4 callbacks:

extension FABMenuController {
    fileprivate func prepareFABMenu() {
        ...
        fabMenu.handleFABButtonCallback = handleFABButtonCallback
        fabMenu.handleOpenCallback = handleOpenCallback
        fabMenu.handleCloseCallback = handleCloseCallback
        fabMenu.handleCompletionCallback = handleCompletionCallback
    }
}

One way to avoid this is to use weak references in the callbacks:

fabMenu.handleFABButtonCallback = { [weak self] button in self?.handleFABButtonCallback(button: button) }
fabMenu.handleOpenCallback = { [weak self] in self?.handleOpenCallback() }
fabMenu.handleCloseCallback = { [weak self] in self?.handleCloseCallback() }
fabMenu.handleCompletionCallback = { [weak self] view in self?.handleCompletionCallback(view: view) }

This did fix the problem in my case.

Am I correct or am I missing something?
Do you see better ways to solve this problem?

Thanks.

[daniel-jonathan]

I will take a look, nice catch :)

[comaxime]

thanks @DanielDahan ;)

[daniel-jonathan]

@comaxime For now, your solution looks great :) I am going to make a push now. All the best!