Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch: toggle completion not call #1245

Closed
linhCrystal opened this issue Jun 7, 2019 · 5 comments
Closed

Switch: toggle completion not call #1245

linhCrystal opened this issue Jun 7, 2019 · 5 comments

Comments

@linhCrystal
Copy link

In func toggle have isTriggeredByUserInteraction: false, completion: completion.
But completion not trigger because isTriggeredByUserInteraction = false

@OrkhanAlikhanov
Copy link
Contributor

Hey! Yes, that's by design. What are you trying to achieve?

@linhCrystal
Copy link
Author

@OrkhanAlikhanov completion in func toggle will be useless if it's never trigger.
Should have move completion?(s) to before guard isTriggeredByUserInteraction else in func updateSwitchState.

@OrkhanAlikhanov
Copy link
Contributor

OrkhanAlikhanov commented Jun 7, 2019

Lol, yeah. That's absolutely right. Will fix that. Thank you!

@daniel-jonathan
Copy link
Member

@linhCrystal I will be fixing this tonight, thank you!

@daniel-jonathan
Copy link
Member

@linhCrystal please find a fix in Material 3.1.6. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants