Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor chore #1265

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Minor chore #1265

merged 1 commit into from
Mar 16, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 15, 2023

After #1261

  • Regenerate from proto
  • Remove dead code
  • Format and polish code

/cc @faddat

@@ -14,7 +14,7 @@ import (
"net/http"

"github.com/golang/protobuf/descriptor"
"github.com/cosmos/gogoproto/proto"
"github.com/golang/protobuf/proto"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerated via make proto-all.
The SDK .gw files have github.com/golang/protobuf as well.

@@ -1,4 +1,3 @@
//nolint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter and formatter where fighting on this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would hate that line, great catch!

@alpe alpe requested a review from pinosu March 16, 2023 08:54
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit c245f7d into develop_sdk47 Mar 16, 2023
@alpe alpe deleted the chore_dev branch March 16, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants