Cosmos-SDK v0.47 integration brach #1149

alpe · 2023-01-11T10:17:32Z

Resolves #1028

Time to bring this branch to main

🚨 Warning: The sdk version used, includes some key store migration. Make sure you backup your private keys before testing this! You can not switch back to v0.45 afaik

🚨 Warning: Take care that you use the goleveldb version used in the SDK. A transitive dependency may change it which caused failing queries on a running server: Error: rpc error: code = InvalidArgument desc = failed to load state at height 1; version does not exist (latest height: 1): invalid request
Ensure:
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7

🚨 Warning: CometBFT contains breaking changes to Tendermint
🚨 Warning: Use new proto-builder version (Makefile) to let proto types register with the correct registry, see
🚨 Warning: Ensure that all ParameterChangeProposal are completed before the upgrade or migrate them to v1.gov. SDK and wasm modules execute a migration before so that these proposals would not have an affect
🚨 Warning: attribute keys/ values are strings and not bytes in CometBFT. This may break clients

💡 Info: CLI: add-genesis-account, gentx,add-genesis-account, collect-gentxs and others are now under genesis command as parent

Follow ups:

Use v1 gov Messages Replace v1beta1 gov with v1 where possible (47) #1246
Set to final ibc-go tag in go.mod

* Upgrade to sdk v0.47 branch * More integration work * SDK version upgrade; fixes * More fixes * Fixes * Deactivate failing tests * SDK + ibc-go version upgrades * limix gas fix (cherry picked from commit f7f8417) * with valset in bench (cherry picked from commit 35b2a8f) * Revert staking query handler; fix tests * Minor cleanup * Rebased * Address linter issues * Set legacy router proper * Deactivate failing test. Race condition needs to handled in SDK * Address some code smells * Bump sdk version * Use gov v1 internally for votes * Activate test after sdk fix * Add group test * Add config template for wasm fields * Add Rust backtrace flag for more debug output on simulations * Set unique node folder for tests * Revert "Add Rust backtrace flag for more debug output on simulations" This reverts commit 218c3c6. * Simulations * Run also im/export + deterministic sims * Add package prefix to interfaces * Add signer annotation (cosmos/cosmos-sdk#10933), minor cleanup * Bump sdk version * Review comments Co-authored-by: vuong <[email protected]>

codecov · 2023-01-11T10:43:46Z

Codecov Report

Merging #1149 (49ed6f0) into main (bc0e817) will increase coverage by 1.97%.
The diff coverage is 64.21%.

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   57.49%   59.46%   +1.97%     
==========================================
  Files          55       57       +2     
  Lines        7460     7320     -140     
==========================================
+ Hits         4289     4353      +64     
+ Misses       2865     2653     -212     
- Partials      306      314       +8

Impacted Files	Coverage Δ
x/wasm/client/cli/new_tx.go	`0.00% <0.00%> (ø)`
x/wasm/client/cli/tx.go	`13.25% <0.00%> (-0.54%)`	⬇️
x/wasm/types/keys.go	`60.71% <ø> (ø)`
x/wasm/types/params_legacy.go	`0.00% <0.00%> (ø)`
x/wasm/ibc.go	`67.23% <4.34%> (ø)`
app/export.go	`12.00% <11.76%> (-0.13%)`	⬇️
x/wasm/keeper/query_plugins.go	`82.60% <11.76%> (ø)`
x/wasm/client/cli/gov_tx.go	`13.12% <14.28%> (+0.83%)`	⬆️
x/wasm/keeper/msg_server.go	`25.38% <30.76%> (-0.87%)`	⬇️
x/wasm/keeper/proposal_handler.go	`64.82% <30.76%> (+0.82%)`	⬆️
... and 33 more

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit f490595)

Bump bufbuild/buf-setup-action from 1.11.0 to 1.12.0 (backport #1151)

(cherry picked from commit 38d466a)

Remove intertx for vanilla ICA

Fix msg format in EVENTS.md (backport #1167)

* Better to sdk coin convertion * Review feedback (cherry picked from commit a925a9e)

Better to sdk coin convertion (backport #1164)

* Remove AccessTypeOnlyAddress for store msg * Remove AccessTypeOnlyAddress for update config msg * Review feedback Co-authored-by: Simon Warta <[email protected]> Co-authored-by: Simon Warta <[email protected]> (cherry picked from commit 8991633)

* Integrate wasmvm v1.2.0 (#1161) * Bump wasmvm version * Bump wasm test contracts * Encode weighted votes * Encode instantiate2 * Handle code info query; better wasmvm errors * Fix readme * Make linter happy * add non cgo build * Review comments * Bump wasmvm to release version Co-authored-by: jhernandezb <[email protected]> (cherry picked from commit 957b38e) # Conflicts: # x/wasm/keeper/handler_plugin_encoders.go # x/wasm/keeper/handler_plugin_encoders_test.go # x/wasm/keeper/keeper.go # x/wasm/keeper/keeper_test.go * Adress merge conflicts Co-authored-by: Alexander Peters <[email protected]>

Disallow only address permission (backport #1163)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.12.0...v1.13.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit ffa0e5e)

(cherry picked from commit c9e7830)

Bump bufbuild/buf-setup-action from 1.12.0 to 1.13.0 (backport #1181)

* Bump sdk version to lastest * Bump ibc-go version to lastest * Remove channel hack

Emit events for setContractAdmin + setAccessConfig (backport #1179)

Update to ibc-go v7 beta2 + protoVer=0.11.5

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.0 to 1.13.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.0...v1.13.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit de27e7f)

Bump bufbuild/buf-setup-action from 1.13.0 to 1.13.1 (backport #1191)

* Fix typos (cherry picked from commit c88b819) # Conflicts: # proto/cosmwasm/wasm/v1/tx.proto * Fix merge conflict --------- Co-authored-by: Alex Peters <[email protected]>

alpe · 2023-02-02T12:50:15Z

🚨 Please see https://twitter.com/CosmWasm/status/1620783214125256704

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.1 to 1.14.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.1...v1.14.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit f3fc31c)

Bump bufbuild/buf-setup-action from 1.13.1 to 1.14.0 (backport #1200)

faddat · 2023-03-15T16:24:46Z

@pinosu @alpe thanks so much for getting the lint PR in as well as #1265.

That will make this branch way easier to develop, review and use.

Also, I can now close #1202

Minor chore

* Set SDK version to v0.47x.0 * Set chainID * Minor updates * Set chainID for simulations * Buf mod update * Use sdk tag instead of hash in buf

faddat · 2023-03-17T09:43:39Z

Hey, I have had a look over this, and I believe that it is good to go. I'm also creating an issue about what I believe is called conformance testing, but I'm not certain I even have the correct name for the type of testing that I'm interested in either adding or seeing added to WASMD.

Basically when looking through the test, the thing that I believe is missing is something that attempts to do as many random things as possible with contracts in an effort to find bugs. Overall I think that that tests here are really very rigorous and it's one of the more pleasant parts of working with WASMD, because I believe that we would catch most things. So if it's cool with you, what I'm going to do is I'm going to approve this, and I'm going to create an issue describing a class of tests that I'm interested in for this code.

faddat

waiting on the removal of propsal types and will re-review then

alpe · 2023-03-17T14:34:01Z

@faddat thanks for the review!

There are quite some changes in the PR. I will keep it open for more feedback and merge on Monday. #1269 is not blocking this and will land in main shortly afterwards.

faddat · 2023-03-17T14:37:37Z

Ahh okay very nice. I'll have another go-through over the weekend, and I'm working to get a build of juno working with this code, too.

Bump ibc-go to v7.0.0

undefined

faddat · 2023-03-20T08:27:23Z

@alpe thanks so much for the work you out into this one. I like the state of the release a lot.

pinosu

Great job! 💯

faddat · 2023-03-20T08:54:03Z

thanks to you too @pinosu

* Backport subset of CosmWasm#1149 * Update CHANGELOG.md * Update dependencies

…105) * feat: apply Finschia/finschia-sdk#1063 (#81) * Backport subset of CosmWasm#1149 * Update CHANGELOG.md * Update dependencies * build: bump finschia-sdk from v0.48.0-rc1 to v0.48.0-rc2 * fix: delete message event Because message event move to finschia-sdk * docs: add CHANGELOG * reflect comment

* Backport subset of CosmWasm#1149 * Update CHANGELOG.md * Update dependencies

dependabot bot and others added 3 commits January 13, 2023 11:10

Merge pull request #1152 from CosmWasm/mergify/bp/develop_sdk47/pr-1151

e9a80cf

Bump bufbuild/buf-setup-action from 1.11.0 to 1.12.0 (backport #1151)

Remove intertx for vanilla ICA

ba499ae

alpe mentioned this pull request Jan 19, 2023

lint tests #1130

Closed

pyramation mentioned this pull request Jan 21, 2023

update interface proto annotations #1156

Merged

dev8723 and others added 18 commits January 23, 2023 09:22

fix msg format in EVENTS.md

50bda42

(cherry picked from commit 38d466a)

Merge pull request #1159 from CosmWasm/ica_noauth

42dc194

Remove intertx for vanilla ICA

Merge pull request #1168 from CosmWasm/mergify/bp/develop_sdk47/pr-1167

22880a8

Fix msg format in EVENTS.md (backport #1167)

Better to sdk coin convertion (#1164)

cc28399

* Better to sdk coin convertion * Review feedback (cherry picked from commit a925a9e)

Merge pull request #1170 from CosmWasm/mergify/bp/develop_sdk47/pr-1164

650af69

Better to sdk coin convertion (backport #1164)

Merge pull request #1176 from CosmWasm/mergify/bp/develop_sdk47/pr-1163

fe57635

Disallow only address permission (backport #1163)

Emit events for setContractAdmin + setAccessConfig (#1179)

db503d6

(cherry picked from commit c9e7830)

Merge pull request #1186 from CosmWasm/mergify/bp/develop_sdk47/pr-1181

83142ba

Bump bufbuild/buf-setup-action from 1.12.0 to 1.13.0 (backport #1181)

Dependency upgrades (#1172)

aa8db78

* Bump sdk version to lastest * Bump ibc-go version to lastest * Remove channel hack

Merge pull request #1187 from CosmWasm/mergify/bp/develop_sdk47/pr-1179

9df3f60

Emit events for setContractAdmin + setAccessConfig (backport #1179)

Update to ibc-go v7 + protoVer=0.11.5

6a0c2a3

Merge pull request #1190 from gjermundgaraba/develop_sdk47

6a49301

Update to ibc-go v7 beta2 + protoVer=0.11.5

Merge pull request #1193 from CosmWasm/mergify/bp/develop_sdk47/pr-1191

a6fcba2

Bump bufbuild/buf-setup-action from 1.13.0 to 1.13.1 (backport #1191)

Fix typos (backport #1185) (#1194)

388b175

* Fix typos (cherry picked from commit c88b819) # Conflicts: # proto/cosmwasm/wasm/v1/tx.proto * Fix merge conflict --------- Co-authored-by: Alex Peters <[email protected]>

This was referenced Feb 25, 2023

47 with token factory #1209

Closed

47 with token factory #1214

Closed

dependabot bot and others added 2 commits March 1, 2023 10:58

Merge pull request #1219 from CosmWasm/mergify/bp/develop_sdk47/pr-1200

fc4bbe1

Bump bufbuild/buf-setup-action from 1.13.1 to 1.14.0 (backport #1200)

Regenerate from proto; remove dead code; polish code

299f792

faddat mentioned this pull request Mar 15, 2023

sdk 47 working branch #1202

Closed

alpe mentioned this pull request Mar 16, 2023

Replace Tendermint with Comet BFT #1217

Closed

alpe added 2 commits March 16, 2023 10:40

Merge pull request #1265 from CosmWasm/chore_dev

c245f7d

Minor chore

Set SDK version to v0.47x.0 (#1262)

6ad6739

* Set SDK version to v0.47x.0 * Set chainID * Minor updates * Set chainID for simulations * Buf mod update * Use sdk tag instead of hash in buf

alpe changed the title ~~[DO NOT MERGE] Cosmos-SDK v0.47 integration brach~~ Cosmos-SDK v0.47 integration brach Mar 16, 2023

alpe marked this pull request as ready for review March 16, 2023 13:47

faddat approved these changes Mar 17, 2023

View reviewed changes

faddat mentioned this pull request Mar 17, 2023

Test ideas #1270

Closed

faddat reviewed Mar 17, 2023

View reviewed changes

gjermundgaraba and others added 3 commits March 19, 2023 16:31

Bump ibc-go to v7.0.0

8579a24

Merge pull request #1275 from gjermundgaraba/bump_ibc_to_7

f66036a

Bump ibc-go to v7.0.0

faddat/re merge main (#1274)

49ed6f0

undefined

alpe mentioned this pull request Mar 20, 2023

lint main branch #1272

Closed

faddat approved these changes Mar 20, 2023

View reviewed changes

pinosu approved these changes Mar 20, 2023

View reviewed changes

alpe merged commit 7e936c7 into main Mar 20, 2023

alpe deleted the develop_sdk47 branch March 20, 2023 09:32

0Tech added a commit to 0Tech/wasmd that referenced this pull request Aug 16, 2023

Backport subset of CosmWasm#1149

d3096d6

0Tech added a commit to 0Tech/wasmd that referenced this pull request Aug 17, 2023

Backport subset of CosmWasm#1149

2490abf

0Tech added a commit to Finschia/wasmd that referenced this pull request Aug 18, 2023

feat: apply Finschia/finschia-sdk#1063 (#81)

516eaae

* Backport subset of CosmWasm#1149 * Update CHANGELOG.md * Update dependencies

da1suk8 added a commit to da1suk8/wasmd that referenced this pull request Aug 25, 2023

feat: apply Finschia/finschia-sdk#1063 (Finschia#81)

6ed67c8

* Backport subset of CosmWasm#1149 * Update CHANGELOG.md * Update dependencies

0Tech added a commit to Finschia/wasmd that referenced this pull request Nov 27, 2023

feat: apply Finschia/finschia-sdk#1063 (#81)

1aaa8e0

* Backport subset of CosmWasm#1149 * Update CHANGELOG.md * Update dependencies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cosmos-SDK v0.47 integration brach #1149

Cosmos-SDK v0.47 integration brach #1149

alpe commented Jan 11, 2023 •

edited

Loading

codecov bot commented Jan 11, 2023 •

edited

Loading

alpe commented Feb 2, 2023

faddat commented Mar 15, 2023

faddat commented Mar 17, 2023

faddat left a comment

alpe commented Mar 17, 2023

faddat commented Mar 17, 2023

faddat commented Mar 20, 2023

pinosu left a comment

faddat commented Mar 20, 2023

Cosmos-SDK v0.47 integration brach #1149

Cosmos-SDK v0.47 integration brach #1149

Conversation

alpe commented Jan 11, 2023 • edited Loading

codecov bot commented Jan 11, 2023 • edited Loading

Codecov Report

alpe commented Feb 2, 2023

faddat commented Mar 15, 2023

faddat commented Mar 17, 2023

faddat left a comment

Choose a reason for hiding this comment

alpe commented Mar 17, 2023

faddat commented Mar 17, 2023

faddat commented Mar 20, 2023

pinosu left a comment

Choose a reason for hiding this comment

faddat commented Mar 20, 2023

alpe commented Jan 11, 2023 •

edited

Loading

codecov bot commented Jan 11, 2023 •

edited

Loading