-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AcceptListStargateQuerier #1069
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
+ Coverage 59.28% 59.30% +0.02%
==========================================
Files 53 53
Lines 6722 6755 +33
==========================================
+ Hits 3985 4006 +21
- Misses 2442 2453 +11
- Partials 295 296 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! LGTM 👍 just a typo needs to be fixed in the test name.
* Stargate query enable * Remove initialized whitelists * Roman's review * Minor improvement * Add tests * Add testings and codec * Fix lint * Fix test * Fix from code review * Refactor Stargate querier init * Fix typo Co-authored-by: mattverse <[email protected]>
* Stargate query enable * Remove initialized whitelists * Roman's review * Minor improvement * Add tests * Add testings and codec * Fix lint * Fix test * Fix from code review * Refactor Stargate querier init * Fix typo Co-authored-by: mattverse <[email protected]>
* Stargate query enable * Remove initialized whitelists * Roman's review * Minor improvement * Add tests * Add testings and codec * Fix lint * Fix test * Fix from code review * Refactor Stargate querier init * Fix typo Co-authored-by: mattverse <[email protected]>
* Stargate query enable * Remove initialized whitelists * Roman's review * Minor improvement * Add tests * Add testings and codec * Fix lint * Fix test * Fix from code review * Refactor Stargate querier init * Fix typo Co-authored-by: mattverse <[email protected]>
* Stargate query enable * Remove initialized whitelists * Roman's review * Minor improvement * Add tests * Add testings and codec * Fix lint * Fix test * Fix from code review * Refactor Stargate querier init * Fix typo Co-authored-by: mattverse <[email protected]>
* Introduce AcceptListStargateQuerier (CosmWasm#1069) * Stargate query enable * Remove initialized whitelists * Roman's review * Minor improvement * Add tests * Add testings and codec * Fix lint * Fix test * Fix from code review * Refactor Stargate querier init * Fix typo Co-authored-by: mattverse <[email protected]> * docs: add changelog --------- Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: mattverse <[email protected]>
Resolves #904
This PR is based on the excellent work in #971 by @mattverse . Thanks a lot for your PR!
I rebased the branch on top of current main and refactored the accept list setup and initialization for backward compatibility and smooth integration into our constructor
option
model.The default mode is still rejecting Stargate queries. I made this an explicit handler:
RejectStargateQuerier
If any chain wants to maintain and enable a set of Stargate queries, it can easily configured via
WithQueryPlugins
option, now. This is a full example:Note for the reviewer:
Beside rebasing all only the last commit was added. Please squash commits