You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We were following the SDK on the keyring + go-keychain dependencies. There had been odd compiler warnings for some time already but now it seems that people have real issues with the versions.
See #950 and linked issue for context.
in our go.mod
github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d // indirect
replace(
// Use the cosmos-flavored keyring library
github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76
I did some a quick research what other versions are used. See below.
The recent github.com/cosmos/keyring 1.2.0 seems to remove the warnings I will do more testing with the keyring but I'll likely prefer using this fork, however I don't think this will have any effect on projects that are including a replace directive on their go.mod (like is our case)
osmosis v11 and Gaia main seem to be in agreement and I would trust the choices they make.
Those are two of the most knowledgeable teams about Cosmos SDK internals and working in those repos to provide stable features for production blockchain.
We were following the SDK on the keyring + go-keychain dependencies. There had been odd compiler warnings for some time already but now it seems that people have real issues with the versions.
See #950 and linked issue for context.
in our go.mod
I did some a quick research what other versions are used. See below.
go-keychain
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4
gaia-main, osmosis v11, sdk main, #950github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d
terra v2, juno v9, sdk v0.45.7, stargaze v6keyring
github.com/cosmos/keyring v1.2.0
sdk maingithub.com/99designs/keyring v1.2.1
gaia main, osmosis v11github.com/99designs/keyring v1.1.6
juno v9, terra v2.1github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76
stargaze , sdk v0.45.7github.com/99designs/keyring v1.1.6
Next
Before upgrading the dependencies, I would love to hear some feedback from the community. Any pros or cons to follow Osmosis versions would be great!
The text was updated successfully, but these errors were encountered: