New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize BalanceQuery in query plugin #606

Closed

alpe opened this issue Sep 13, 2021 · 1 comment · Fixed by #609

Milestone

Contributor

alpe commented Sep 13, 2021

We can use GetBalance now instead of iterating through the list

alpe added this to the v0.20.0 milestone

Member

ethanfrey commented Sep 13, 2021

Very good point and much more efficient. This is why there were two different queries in the first place.

I was surprised to find https://github.com/CosmWasm/wasmd/blob/master/x/wasm/keeper/query_plugins.go#L171-L178 wasn't updated after the Stargate upgrade. But so many things to do there.

alpe mentioned this issue

Optimize BalanceQuery #609

Merged

alpe closed this as completed in #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment