Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in query handler initialization on reply #604

Closed
alpe opened this issue Sep 10, 2021 · 3 comments · Fixed by #607
Closed

Fix bug in query handler initialization on reply #604

alpe opened this issue Sep 10, 2021 · 3 comments · Fixed by #607
Labels
bug Something isn't working
Milestone
v0.19.0

Comments

@alpe
Copy link
Contributor

alpe commented Sep 10, 2021

🙅 https://github.com/CosmWasm/wasmd/blob/v0.18.0/x/wasm/keeper/keeper.go#L486-L489
@alpe alpe added this to the 0.19.0 milestone Sep 10, 2021
@alpe alpe added the bug Something isn't working label Sep 10, 2021
@alpe alpe modified the milestones: 0.19.0, v0.18.1 Sep 10, 2021
@alpe alpe assigned alpe and unassigned alpe Sep 10, 2021
@ethanfrey
Copy link
Member

Good find. Let's patch this.

@alpe alpe modified the milestones: v0.18.1, 0.19.0 Sep 13, 2021
@alpe
Copy link
Contributor Author

alpe commented Sep 13, 2021

A fix would be consensus breaking. Moving this to v0.19.0

@alpe alpe mentioned this issue Sep 13, 2021
Merged
@ethanfrey
Copy link
Member

I agree. Let's merge and get in a 0.19.0 sometime soonish...

I guess this needs a x/upgrade on any chains. But no migration needed.

@alpe alpe closed this as completed in #607 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging a pull request may close this issue.

Fix query handler instantiation CosmWasm/wasmd
2 participants
@alpe @ethanfrey