Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump proto definitions to version 1 #558

Closed
2 tasks done
webmaster128 opened this issue Jul 19, 2021 · 2 comments · Fixed by #563
Closed
2 tasks done

Bump proto definitions to version 1 #558

webmaster128 opened this issue Jul 19, 2021 · 2 comments · Fixed by #563
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented Jul 19, 2021

The Cosmos SDK is struggeling with protobuf version changes to the degree that it becomes clear releasing Stargate with "v1beta1" was a mistake. The plan is not to use the simple linear versioning with "v1" from 0.44 on (cosmos/cosmos-sdk#9446 (comment)).

We can avoid repeating this mistake and start the version counting now with v1.

Proposed changes in v1:

  • MsgMigrateContract.migrateMsg -> .msg (analogue to MsgExecuteContract)
  • MsgInstantiateContract.initMsg -> .msg (analogue to MsgExecuteContract)
@webmaster128 webmaster128 added this to the v0.18.0 milestone Jul 19, 2021
@ethanfrey
Copy link
Member

Yeah, backwards compatibility is a bit harder than it looks like. And hiding behind "beta" doesn't really help when the code is on many main nets.

Let's make a final v1 and stick with it.

@webmaster128
Copy link
Member Author

v1 should be the protobuf version for 0.18. If we need a v2, v3, v4, … on the way to wasmd 1.0, then this is fine. Clients can handle it.

@ethanfrey ethanfrey mentioned this issue Jul 27, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants