-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out Message events before calling submessage response #448
Comments
I actually depend on the message event from submessage being present in the reply: https://github.com/CosmWasm/cosmwasm/blob/main/contracts/ibc-reflect/src/contract.rs#L39-L94 I didn't know a more reliable way to get the contract address from a newly created contract |
The Instantiate method returns the address but it is in a protobuf type: https://github.com/CosmWasm/wasmd/blob/v0.16.0/x/wasm/keeper/msg_server.go#L72 |
Let's find a good solution to the ibc-reflect contract before changing this in wasmd. |
I have seen TerraSwap parses the InstantiateMsg data field. I can also hand-write a parser that doesn't involve prost/protobuf library. We should add something like this to |
I think we also need a larger discussion about Events. There are 2 usages of Events now - for reply and to return to clients. Do we need the same rules for both of them? Also, many of our rules are to work around the fact that Tendermint would flatten them, so all So, I would like to remove workarounds inspired by the poor Tendermint behavior in the API we expose to contracts, which should be stable. That is - |
Follow up from #441 (comment)
The text was updated successfully, but these errors were encountered: