Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Event Handling in BaseApp/Tendermint #368

Closed
ethanfrey opened this issue Jan 8, 2021 · 2 comments
Closed

Investigate Event Handling in BaseApp/Tendermint #368

ethanfrey opened this issue Jan 8, 2021 · 2 comments
Labels
on hold Let's pause this and come back in a week...

Comments

@ethanfrey
Copy link
Member

We may return many events with the same type and want to return them all.

For example, if the user sends tokens to an contract, and the contract sends tokens to a 3rd party, there will be 2 bank sends with the same message type. Once upon a time (launchpad) these ended up merged together and a client app would no have access to both events. This also affects when one contract calls a sub-contract, and those other calls get hidden.

Let's investigate the current situation of event merging in the path from contract/handler to external client (over tendermint rpc). Also what is left when we search for events in tendermint.

Then we can propose possible changes to the sdk or to our internal handling of events/attributes

@ethanfrey
Copy link
Member Author

These are still collapsed, apparently in the Tendermint level

I raised an issue on cosmos-sdk: cosmos/cosmos-sdk#8419 which is related to a Tendermint issue tendermint/tendermint#5133

Nothing else we can do but track those (or comment on them)

@ethanfrey ethanfrey added the on hold Let's pause this and come back in a week... label Jan 29, 2021
@ethanfrey
Copy link
Member Author

This has now been fixed in Tendermint and latest Cosmos SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Let's pause this and come back in a week...
Projects
None yet
Development

No branches or pull requests

1 participant