-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit init/migrate/execute payload message size #203
Comments
You have to pay gas for them, and they cost lots of wasm gas to process. It might make sense to produce a reasonable limit on them, but what is reasonable? If I want to start an erc20 like contract with eg. 5000 addresses from some import, that will be easily 200kb. I would rely on the tx gas limit and byte size to enforce this |
Unless you have an objection, I would close this and just rely on other controls (like "max tx bytes" and "gas cost per tx byte") to limit this |
Thanks for the updates. A scenario I had in mind was a contract that returns a very big message. Tx limits would not apply here as we dispatch them internally. I hope this is covered. 🤞 |
You are right, this could be quite large. But as soon as we write this to the migration history, it will charge a bunch of gas based on size. I don't see a need for explicit limits, but if you want to make some (very large) ones, like 64kB, that is fine |
Instead of a hard byte size lime we can charge for the bytes as proposed in option 2 in #297 |
Let's do that. |
Summary
There are currently no limits to the msg payload in
MsgInstantiateContract
,MsgMigrateContract
andMsgExecuteContract
. Should we set limit for external/ dispatched messages?For Admin Use
The text was updated successfully, but these errors were encountered: