Add workspace optimizer

[webmaster128]

Misses a lot of documentation but should be basically feature complete.

[webmaster128]

Open problems:

1. Removing the executable bit from the *.wasm files does not seem to work
2. The guest writed unwanted data to the host:

        contracts/cw1-subkeys/contract_artifacts/
        contracts/cw1-whitelist/contract_artifacts/
        contracts/cw1-whitelist/foobar/
        contracts/cw20-base/contract_artifacts/
        contracts/cw20-escrow/contract_artifacts/
   

3. Docs missing

[ethanfrey]

Nice work. I will finish it.

[ethanfrey]

Okay, nightly rust for determinstic compilation seems odd to me. I guess you are pinning it to nightly-2020-08-20 not just any nightly, but still feels odd.

[webmaster128]

Yes. Not optimal but I also don't see an issue with this. Unfortunately there is not versioned nightly tag on docker directly, so we have to install it manually.

[ethanfrey]

This seems quite complex way to do contracts/*
"Get all and take those that start with contracts/" is basically that, but none if contracts are not in members. Can't we just assume that

[webmaster128]

I'd see this as a transition from searching Cargo.tomls to parsing and understanding the workspace. The current path filter is probably not ideal. Maybe we end up with a way to filter contracts from non-contracts using a more stable way.

But this is already an improvement over path search since you can specify members = ["contracts/a", "contracts/b", "packages/*"] and then contracts/c will not be built since it is not in the workspace.

[ethanfrey]

We can remove the ./contracts_artifacts dir after this loop, right?

[webmaster128]

Right, that should do the job. Even better would be to write the output to a place outside of /code, such that you never need to touch the host filesystem for this step. Ideally using

import tempfile

# ...

for contract in contract_packages:
    log("Building {} ...".format(contract))
    with tempfile.TemporaryDirectory() as out_dir:
        # Rust nightly and unstable-options is needed to use --out-dir
        cmd = [CARGO_PATH, "-Z=unstable-options", "build", "--release", "--target=wasm32-unknown-unknown", "--locked", "--out-dir={}".format(out_dir)]
        os.environ["RUSTFLAGS"] = "-C link-arg=-s"
        subprocess.check_call(cmd, cwd=contract)
        for build_result in glob.glob(out_dir + "/*.wasm"):
            log("Optimizing built {} ...".format(build_result))
            name = os.path.basename(build_result)
            cmd = ["wasm-opt", "-Os", "-o", "artifacts/{}".format(name), build_result]
            subprocess.check_call(cmd)

(untested)

[ethanfrey]

Done without the with (no need to clean up the temp dir on docker).

But result same: not touching host filesystem for out_dir

[ethanfrey]

I think this is done now. I will merge and publish shortly.