Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache metrics #877

Merged
merged 5 commits into from
Apr 14, 2021
Merged

Add cache metrics #877

merged 5 commits into from
Apr 14, 2021

Conversation

webmaster128
Copy link
Member

Closes #763

@webmaster128 webmaster128 mentioned this pull request Apr 13, 2021
Closed
@webmaster128 webmaster128 requested a review from maurolacy April 13, 2021 18:56
maurolacy
maurolacy approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

packages/vm/src/modules/in_memory_cache.rs Show resolved Hide resolved
packages/vm/src/modules/pinned_memory_cache.rs Show resolved Hide resolved
@webmaster128 webmaster128 added the automerge See mergify.io label Apr 14, 2021
@mergify mergify bot merged commit 1f43164 into main Apr 14, 2021
@mergify mergify bot deleted the add-cache-metrics branch April 14, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
automerge See mergify.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Metrics for Cache
2 participants
@webmaster128 @maurolacy