Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set cranelift feature by default for integration testing #834

Closed
wants to merge 1 commit into from

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Mar 9, 2021

Singlepass now runs on 64 bit Windows, such that non-singlepass use cases became rare enough to ignore stop optimizing for them.

Closes #649

@webmaster128
Copy link
Member Author

Looks like singlepass still cannot compile for Windows targets: https://github.com/wasmerio/wasmer/blob/1.0.2/lib/compiler-singlepass/src/compiler.rs#L51-L55

@webmaster128 webmaster128 marked this pull request as draft March 9, 2021 16:31
@maurolacy
Copy link
Contributor

Looks like singlepass still cannot compile for Windows targets: https://github.com/wasmerio/wasmer/blob/1.0.2/lib/compiler-singlepass/src/compiler.rs#L51-L55

I've read somewhere (cannot recall where) that there have been changes in that regard?. Maybe asking them? In any case, we can save this change for the (near?) future.

@maurolacy
Copy link
Contributor

maurolacy commented Mar 9, 2021

Here it is: CosmWasm/wasmvm#28. I've seen you already posted a comment. 👍🏼

@webmaster128
Copy link
Member Author

We'll get back to this once there is singlepass support for Windows

@webmaster128 webmaster128 deleted the default-to-singlepass branch July 15, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OS specific default backend in integration tests
2 participants