Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump module serialization version #1911

Closed
webmaster128 opened this issue Oct 8, 2023 · 2 comments · Fixed by #1913
Closed

Bump module serialization version #1911

webmaster128 opened this issue Oct 8, 2023 · 2 comments · Fixed by #1913
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented Oct 8, 2023

  • Bump module serialization version due to Wasmer upgrade in 1.4 -> 1.5. We were warned by the Wasmer team long time ago that we should not expect module compatibility across Wasmer versions.
  • Let's add a .module file extension to the module files to make it easier for node operators to reason about those things
@webmaster128 webmaster128 added this to the 1.5.0 milestone Oct 8, 2023
@chipshort
Copy link
Collaborator

Isn't the cache invalidated already since the wasmer module version increased?

@webmaster128
Copy link
Member Author

Isn't the cache invalidated already since the wasmer module version increased?

In theory this should always bee there case. Seems like it worked here. But we also has cases in the past in which the automatic bumping did not work but the modules were still incompatible. By bumping our version, we are on the safe side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants