You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some messages (eg. WasmMsg::Execute) contains Binary field being actually a json message passed to something. Technically speaking this is chunk of bytes, practically speaking - it is [almost] always a json. After all, on test using MT I get a result like:
And obviously having an actuall message here would be very helpful. Creating custom debug impl which prints this binary as string would be probably easier to work with.
The text was updated successfully, but these errors were encountered:
This is a follow up from #1199 (note this Debug is better than before)
Simon objected to making assumptions that this is a readable string. (And sometimes, this is raw bytes, like u64 big endian encoded). Happy to revisit, but please read the discussion on the linked issue
When we have the Binary embedded in some context, I think it is fair to optimize for the expected content as long as the general case is supported as a fallback. I.e. I would not change the Debug implementation of Binary but the Debug implementation of WasmMsg::Execute.msg.
Some messages (eg.
WasmMsg::Execute
) containsBinary
field being actually a json message passed to something. Technically speaking this is chunk of bytes, practically speaking - it is [almost] always a json. After all, on test using MT I get a result like:And obviously having an actuall message here would be very helpful. Creating custom debug impl which prints this binary as string would be probably easier to work with.
The text was updated successfully, but these errors were encountered: