Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A typo in the documentation on the website #157

Closed
Tartilla-TAIGO opened this issue Jul 4, 2024 · 4 comments
Closed

A typo in the documentation on the website #157

Tartilla-TAIGO opened this issue Jul 4, 2024 · 4 comments
Assignees

Comments

@Tartilla-TAIGO
Copy link
Contributor

image
Page url: https://kb.corona.studio/enUS/projbobcat/installers/fabric.html

The library code uses System.Text.Json. If you use Newtonsoft.JSON, then an error occurs converting Newtonsoft.Json.JsonElement to System.Text.Json.JsonElement.
The line should be like this:
var artifacts = System.Text.Json.JsonSerializer.Deserialize<List>(responseJson);

@yueyinqiu
Copy link
Member

yueyinqiu commented Jul 4, 2024

yes the whole document is outdated. actually there is no reason to use json.net now. #54

@BiDuang
Copy link
Member

BiDuang commented Aug 30, 2024

yes the whole document is outdated. actually there is no reason to use json.net now. #54

Yeah, recommand to use .Net's native json package now.

@laolarou726
Copy link
Member

fixed

@yueyinqiu
Copy link
Member

??? I failed to find any change here: https://github.com/Corona-Studio/docs/blob/main/enUS/projbobcat/installers/fabric.md

Have we moved it to a new repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants